Skip to content

Fix tooltip spacing #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix tooltip spacing #1435

wants to merge 2 commits into from

Conversation

alarcritty
Copy link
Collaborator

@alarcritty alarcritty commented Jun 26, 2025 •
edited
Loading

Fixes: Tooltip spacing issue for organization/add organization button in the sidebar.
Previously, the tooltip was flush against the sidebar, unlike other sidebar buttons (e.g., Settings, DND, Back, Reload).
This PR introduces proper spacing so that the tooltip now aligns consistently with others, improving visual coherence and user experience.

📸 Before vs. After

Before (tooltip flush) After (proper spacing)
Before Tooltip After Tooltip

🧪 Platforms this PR was tested on:

  • Linux (Ubuntu-based)
  • Linux (Arch)
  • Windows
  • macOS
🧠 Self-review checklist
  • Self-reviewed the changes for clarity and maintainability (e.g., variable names, readability, minimal duplication).
  • Clearly explains differences from previous behavior (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Flags any remaining decisions, assumptions, or concerns.
  • Automated tests verify logic where appropriate.

🧩 Commit discipline:

  • Each commit represents a coherent change.
  • Commit messages explain the reasoning and motivation for the changes.

🧪 Manual review and testing includes:

  • Visual appearance of the fix.
  • Responsiveness and internationalization.
  • Tooltip behavior and string correctness.
  • End-to-end interaction of relevant buttons.
  • Corner cases, error conditions, and potential edge bugs.

@alarcritty
Copy link
Collaborator Author

Hi @zulip/desktop-team 👋

This PR fixes the tooltip spacing issue for the organization and Add Organization buttons in the sidebar.
All checks have passed ✅ and the spacing now aligns consistently with other sidebar tooltips (Settings, DND, etc.).
Screenshots have been added to show the before and after states.

Tested on:

  • Ubuntu-based Linux
  • Arch Linux
  • macOS

Requesting your review when you get a chance. Thanks!

@alarcritty alarcritty mentioned this pull request Jun 26, 2025
Open
@alya
Copy link
Collaborator

alya commented Jun 26, 2025

@shubham-padia Could you please take a look to at this one?

@alarcritty
Copy link
Collaborator Author

Hey @shubham-padia , could you please review it .

@alarcritty alarcritty closed this Aug 18, 2025
@alarcritty alarcritty deleted the fix-tooltip-spacing branch August 18, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintainer review size: XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alarcritty @alya @zulipbot